HappenLee commented on code in PR #17970:
URL: https://github.com/apache/doris/pull/17970#discussion_r1142212050
##########
be/src/vec/functions/array/function_array_binary.h:
##########
@@ -51,26 +53,24 @@ class FunctionArrayBinary : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
size_t result, size_t input_rows_count) override {
- auto left_column =
-
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
- auto right_column =
-
block.get_by_position(arguments[1]).column->convert_to_full_column_if_const();
- Status ret = Status::RuntimeError(
- fmt::format("execute failed, unsupported types for function
{}({}, {})", get_name(),
-
block.get_by_position(arguments[0]).type->get_name(),
-
block.get_by_position(arguments[1]).type->get_name()));
+ auto left_column =
unpack_if_const(block.get_by_position(arguments[0]).column);
+ auto right_column =
unpack_if_const(block.get_by_position(arguments[1]).column);
+
// extract array column
ColumnArrayExecutionData left_data;
ColumnArrayExecutionData right_data;
ColumnPtr res_ptr = nullptr;
if (extract_column_array_info(*left_column, left_data) &&
- extract_column_array_info(*right_column, right_data)) {
- ret = Impl::execute(res_ptr, left_data, right_data);
- }
- if (ret == Status::OK()) {
+ extract_column_array_info(*right_column, right_data) &&
+ Impl::execute(res_ptr, left_data, right_data,
is_column_const(*left_column),
Review Comment:
column is unpack if const, not need call `is_column_const`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
