[GitHub] [doris] HappenLee commented on a diff in pull request #17970: [Optimize](functions)Optimize function call for const columns.

[via GitHub]

HappenLee commented on code in PR #17970:
URL: https://github.com/apache/doris/pull/17970#discussion_r1142206502


##########
be/src/vec/functions/function_bitmap.cpp:
##########
@@ -452,6 +455,22 @@ struct BitmapNot {
         }
         return Status::OK();
     }
+    static Status vector_const(const TData& lvec, const TData& rvec, TData& 
res) {
+        size_t size = lvec.size();
+        for (size_t i = 0; i < size; ++i) {
+            res[i] = lvec[i];
+            res[i] -= rvec[0];

Review Comment:
   directly pass reference， not need [0]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org