airborne12 commented on code in PR #17629:
URL: https://github.com/apache/doris/pull/17629#discussion_r1135435152
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -856,20 +855,24 @@ Status SegmentIterator::_apply_inverted_index() {
size_t input_rows = _row_bitmap.cardinality();
std::vector<ColumnPredicate*> remaining_predicates;
std::set<const ColumnPredicate*> no_need_to_pass_column_predicate_set;
+ std::set<const ColumnPredicate*> remaining_predicates_set;
for (const auto& entry : _opts.col_id_to_predicates) {
ColumnId column_id = entry.first;
auto pred = entry.second;
bool continue_apply = true;
RETURN_IF_ERROR(_apply_inverted_index_on_block_column_predicate(
- column_id, pred.get(), no_need_to_pass_column_predicate_set,
&continue_apply));
+ column_id, pred.get(), no_need_to_pass_column_predicate_set,
+ remaining_predicates_set, &continue_apply));
if (!continue_apply) {
break;
}
}
for (auto pred : _col_predicates) {
- if (no_need_to_pass_column_predicate_set.count(pred) > 0) {
+ if (remaining_predicates_set.count(pred) > 0) {
Review Comment:
if a predicate is marked as remaining_predicates in block_column_predicate,
no need to continue in _apply_inverted_index_on_column_predicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
