airborne12 commented on code in PR #17629:
URL: https://github.com/apache/doris/pull/17629#discussion_r1135429906


##########
be/src/olap/in_list_predicate.h:
##########
@@ -206,13 +206,15 @@ class InListPredicateBase : public ColumnPredicate {
         auto column_desc = schema.column(_column_id);
         std::string column_name = column_desc->name();
         roaring::Roaring indices;
-        for (auto value : *_values) {
-            InvertedIndexQueryType query_type = 
InvertedIndexQueryType::EQUAL_QUERY;
-            roaring::Roaring index;
-            RETURN_IF_ERROR(iterator->read_from_inverted_index(column_name, 
&value, query_type,
-                                                               num_rows, 
&index));
-            indices |= index;
+
+        InvertedIndexQuery<Type> query(column_desc->type_info());

Review Comment:
   cannot, because line 215 is InvertedIndexQueryType, not InvertedIndexQuery



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to