Kikyou1997 commented on code in PR #17637:
URL: https://github.com/apache/doris/pull/17637#discussion_r1133452798
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -221,12 +221,7 @@ public Cost visitPhysicalHashJoin(
pattern2: (L join1 Agg1) join2 agg2
in pattern2, join1 and join2 takes more time, but Agg1 and agg2 can be
processed in parallel.
*/
- double penalty = HEAVY_OPERATOR_PUNISH_FACTOR
- * Math.min(probeStats.getPenalty(), buildStats.getPenalty());
- if (buildStats.getWidth() >= 2) {
- //penalty for right deep tree
- penalty += rightRowCount;
- }
+ double penalty = HEAVY_OPERATOR_PUNISH_FACTOR;
Review Comment:
> 1. this file is CostModelV1. if v2 will replace v1, keep the v1 untouched.
it will work for next few days
> 2. in V2, we still need penalty, especially heavy operator penalty. only
when the parallel parameter between child and parent is 0, the penalty is not
used.
关于第一点我觉得本身代价模型就尚不成熟，另外如果后续发现影响较大可以再把这些逻辑补回来，目前V2的测试比较急，我觉得应该优先考虑V2的工作。流水线现在本身也不稳定且很慢，每次更新一次提交都很耽误时间
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -221,12 +221,7 @@ public Cost visitPhysicalHashJoin(
pattern2: (L join1 Agg1) join2 agg2
in pattern2, join1 and join2 takes more time, but Agg1 and agg2 can be
processed in parallel.
*/
- double penalty = HEAVY_OPERATOR_PUNISH_FACTOR
- * Math.min(probeStats.getPenalty(), buildStats.getPenalty());
- if (buildStats.getWidth() >= 2) {
- //penalty for right deep tree
- penalty += rightRowCount;
- }
+ double penalty = HEAVY_OPERATOR_PUNISH_FACTOR;
Review Comment:
V2 不需要统计信息提供这些字段
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
