Kikyou1997 commented on code in PR #17637:
URL: https://github.com/apache/doris/pull/17637#discussion_r1133284507
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/ExpressionEstimation.java:
##########
@@ -118,13 +164,13 @@ public ColumnStatistic
visitBinaryArithmetic(BinaryArithmetic binaryArithmetic,
double leftNullCount = leftColStats.numNulls;
double rightNullCount = rightColStats.numNulls;
double rowCount = context.getRowCount();
- double numNulls = context.getRowCount()
- * (1 - (1 - (leftNullCount / rowCount) * (1 - rightNullCount /
rowCount)));
+ double numNulls = Math.max(leftNullCount, rightNullCount);
Review Comment:
Seems this change isn't better than original formula, I reverted it,thx for
review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
