yiguolei commented on code in PR #69635:
URL: https://github.com/apache/doris/pull/69635#discussion_r4522210654


##########
be/src/exec/spill/spill_data_dir.cpp:
##########
@@ -0,0 +1,295 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/spill/spill_data_dir.h"
+
+#include <fmt/format.h>
+#include <glog/logging.h>
+#include <sys/statvfs.h>
+
+#include <algorithm>
+#include <cerrno>
+#include <filesystem>
+#include <utility>
+
+#include "common/config.h"
+#include "common/logging.h"
+#include "common/metrics/doris_metrics.h"
+#include "common/metrics/metrics.h"
+#include "io/fs/local_file_system.h"
+#include "storage/olap_define.h"
+#include "util/parse_util.h"
+#include "util/pretty_printer.h"
+
+namespace doris {
+
+DEFINE_COUNTER_METRIC_PROTOTYPE_2ARG(spill_file_created_total, 
MetricUnit::NOUNIT);
+DEFINE_COUNTER_METRIC_PROTOTYPE_2ARG(spill_file_deleted_total, 
MetricUnit::NOUNIT);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(spill_disk_capacity, MetricUnit::BYTES);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(spill_disk_limit, MetricUnit::BYTES);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(spill_disk_avail_capacity, 
MetricUnit::BYTES);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(spill_disk_data_size, MetricUnit::BYTES);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(spill_disk_inode_total, MetricUnit::NOUNIT);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(spill_disk_inode_available, 
MetricUnit::NOUNIT);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(spill_disk_has_spill_data, 
MetricUnit::BYTES);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(spill_disk_has_spill_gc_data, 
MetricUnit::BYTES);
+
+SpillDataDir::SpillDataDir(std::string path, std::string spill_root, const 
std::string& metric_path,
+                           int64_t capacity_bytes, TStorageMedium::type 
storage_medium)
+        : _path(std::move(path)),
+          _spill_root(std::move(spill_root)),
+          _disk_capacity_bytes(capacity_bytes),
+          _storage_medium(storage_medium) {
+    spill_data_dir_metric_entity = 
DorisMetrics::instance()->metric_registry()->register_entity(
+            std::string("spill_data_dir.") + _path, {{"path", metric_path}});
+    INT_COUNTER_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_file_created_total);
+    INT_COUNTER_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_file_deleted_total);
+    INT_GAUGE_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_disk_capacity);
+    INT_GAUGE_METRIC_REGISTER(spill_data_dir_metric_entity, spill_disk_limit);
+    INT_GAUGE_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_disk_avail_capacity);
+    INT_GAUGE_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_disk_data_size);
+    INT_GAUGE_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_disk_inode_total);
+    INT_GAUGE_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_disk_inode_available);
+    INT_GAUGE_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_disk_has_spill_data);
+    INT_GAUGE_METRIC_REGISTER(spill_data_dir_metric_entity, 
spill_disk_has_spill_gc_data);
+}
+
+SpillDataDir::~SpillDataDir() = default;
+
+void SpillDataDir::record_spill_file_created() {
+    spill_file_created_total->increment(1);
+}
+
+void SpillDataDir::record_spill_file_deleted(size_t count) {
+    spill_file_deleted_total->increment(static_cast<int64_t>(count));
+}
+
+std::string SpillDataDir::get_spill_data_path(const std::string& query_id) 
const {
+    DCHECK(ready()) << "spill store is not ready: " << _path;
+    if (query_id.empty()) {
+        return _spill_root;
+    }
+    return fmt::format("{}/{}", _spill_root, query_id);
+}
+
+bool SpillDataDir::reach_capacity_limit(int64_t incoming_data_size) {
+    std::lock_guard<std::mutex> l(_mutex);
+    return _reach_limit_unlocked(incoming_data_size);
+}
+
+Status SpillDataDir::try_reserve(int64_t bytes, bool force) {

Review Comment:
   别加force 参数了,直接写2个函数;一个是try reserver 表示force == false; 另外一个是reserve 表示force 
== true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to