yiguolei commented on code in PR #69635:
URL: https://github.com/apache/doris/pull/69635#discussion_r4522125101
##########
be/src/common/config.cpp:
##########
@@ -1577,10 +1577,31 @@ DEFINE_mDouble(high_disk_avail_level_diff_usages,
"0.15");
DEFINE_Int32(partition_disk_index_lru_size, "10000");
// limit the storage space that query spill files can use
DEFINE_String(spill_storage_root_path, "");
-DEFINE_String(spill_storage_limit, "20%"); // 20%
+DEFINE_String(spill_storage_limit, "20%"); // 20%
+DEFINE_mInt64(spill_storage_limit_bytes, "0");
+DEFINE_Validator(spill_storage_limit_bytes, [](int64_t config) -> bool {
return config >= 0; });
DEFINE_mInt32(spill_gc_interval_ms, "2000"); // 2s
DEFINE_mInt32(spill_gc_work_time_ms, "2000"); // 2s
DEFINE_mInt64(spill_file_part_size_bytes, "1073741824"); // 1GB
+DEFINE_String(spill_storage_type, "local");
+// s3: cloud mode only; spill is written to the S3 storage vault under
+// spill/{ip}_{port}/{query_id}/, where ip is the address of this BE and port
its
+// heartbeat_service_port.
+// The BE deletes the objects of a spill file when the query is done with it.
What a BE that
+// crashed left behind is not deleted by Doris: give the bucket a lifecycle
rule that expires
+// the keys under <vault prefix>/spill/ and aborts incomplete multipart
uploads.
+// Incomplete multipart uploads from failed or cancelled queries also rely on
that rule.
+DEFINE_Validator(spill_storage_type, [](const std::string& config) -> bool {
Review Comment:
local 和 s3 这种名字，最好定义成常量。 因为你再doris main 里似乎也检查这个了，后面如果四处写字面量，容易不好维护
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
