OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4428752564
##########
be/src/format/table/iceberg/types.cpp:
##########
@@ -192,6 +201,31 @@ std::unique_ptr<PrimitiveType>
Types::from_primitive_string(const std::string& t
return std::make_unique<DecimalType>(precision, scale);
}
+ std::regex geometry(R"(geometry\s*(?:\(\s*([^)]*?)\s*\))?)",
std::regex::icase);
+ if (std::regex_match(type_string, match, geometry,
std::regex_constants::match_default)) {
+ const std::string crs =
+ match[1].matched ? trim(match[1].str()) :
GeometryType::DEFAULT_CRS;
+ if (crs.empty()) {
+ throw doris::Exception(doris::ErrorCode::INTERNAL_ERROR,
+ "Invalid CRS: (empty string)");
+ }
+ return std::make_unique<GeometryType>(crs);
+ }
+
Review Comment:
Parse the final Geography algorithm delimiter and preserve the complete CRS
bytes, including embedded NULs, at the BE JSON boundary. Added parser and real
Parquet round-trip coverage; upstream Java parser restrictions are unchanged.
Commit:
[5e8792357496](https://github.com/apache/doris/commit/5e8792357496315bdb67d0ce43666d3cf3d59cf3).
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergTypeMapping.java:
##########
@@ -126,6 +127,13 @@ private static ConnectorType
fromPrimitive(Type.PrimitiveType primitive,
case UUID:
// Preserve logical UUID semantics independently of the binary
mapping option.
return ConnectorType.of("UUID");
Review Comment:
Preserve resolved spatial metadata instead of replacing it with the STRING
placeholder during schema evolution. Added nullable/nested/default and actual
Parquet equality-delete coverage, including annotated/raw-WKB matching without
relaxing spatial identity checks.
Commit:
[5e8792357496](https://github.com/apache/doris/commit/5e8792357496315bdb67d0ce43666d3cf3d59cf3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
