OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4428749764
##########
be/src/core/data_type/define_primitive_type.h:
##########
@@ -75,7 +75,9 @@ enum PrimitiveType : PrimitiveNative {
TYPE_VARBINARY, /* 41, varbinary */
TYPE_TIMESTAMPTZ, /* 42, timestamptz */
TYPE_TIMESTAMP_NS, /* 43, signed Int64 epoch nanoseconds
*/
- TYPE_UUID /* 44, uuid */
+ TYPE_UUID, /* 44, uuid */
+ TYPE_GEOMETRY, /* 45, Iceberg geometry */
Review Comment:
Pinned Iceberg 1.12 already rejects spatial identity partitions during DDL
and typed metadata binding, before BE. Kept real CREATE/ADD/REPLACE rejection
tests and ordinary-partition-key/spatial-value write controls; removed the
redundant checks.
Commit:
[5e8792357496](https://github.com/apache/doris/commit/5e8792357496315bdb67d0ce43666d3cf3d59cf3).
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java:
##########
@@ -119,13 +119,15 @@ public static PushDownContext
createPushDownContext(RuntimeFilterContext rfConte
/**
* A context is valid if probeExpr references exactly one input slot
and both expressions
- * have non-Variant types. Scalar runtime filters cannot express
Variant canonical equality;
- * explicit casts to supported scalar types can still produce runtime
filters.
+ * have supported predicate types. Spatial types have no BE runtime
predicate kernel;
+ * Variant canonical equality is also unsupported. Supported scalar
projections can still filter.
* Invalid when probeExpr is a constant (e.g., from OneRowRelation) or
multi-slot.
*/
public boolean isValid() {
return !srcExpr.getDataType().isVariantType()
&& !probeExpr.getDataType().isVariantType()
+ && !srcExpr.getDataType().isSpatialType()
Review Comment:
Fixed both runtime-filter gates to reject keys recursively containing
spatial types. Six real Iceberg Array-key joins cover IN/MINMAX/Bloom settings
without these filters. Map/Struct equality retains its existing analysis
rejection.
Commit:
[5e8792357496](https://github.com/apache/doris/commit/5e8792357496315bdb67d0ce43666d3cf3d59cf3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
