EscaperLL commented on PR #69666: URL: https://github.com/apache/doris/pull/69666#issuecomment-6438819358
@yiguolei Thanks for triggering the review. All required checks have passed or been skipped as applicable. The remaining coverage failure is 0/1 lines in the FLOAT16 subnormal branch. This PR fixes compilation with older libstdc++; exhaustive numerical validation is documented in the description. Could you review whether the existing validation is sufficient, or a targeted unit test is needed before merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
