EscaperLL commented on PR #69666:
URL: https://github.com/apache/doris/pull/69666#issuecomment-6437507090
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69666
commit: e3d8606ecd2238a5565ed5ba80b1a993165d92d9
base: a626232f5cc1f456117ffe9abca2b3d0578735d4
reviewed_at: 2026-10-27T06:47-02:00
reviewer: EscaperLL
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/format/parquet/parquet_column_convert.h:618` — Source review only;
no builds or tests were run for this review. The PR reports that its full BE
build failed the glibc 2.17 compatibility gate, so a successful standard CI
build is still needed before merging.
- `be/src/format/parquet/parquet_column_convert.h:618` — Existing unit tests
do not directly exercise FLOAT16, and the external FLOAT16 expected results
omit subnormals. The PR discloses these limits; its exhaustive numerical
comparison is author-reported and was not repeated here.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
