Gabriel39 commented on code in PR #69601:
URL: https://github.com/apache/doris/pull/69601#discussion_r4373767599
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -3509,11 +3507,6 @@ public void setDetailShapePlanNodes(String
detailShapePlanNodes) {
+ "non-utf8 characters will be displayed as garbled characters.")
public boolean enableTextValidateUtf8 = true;
- @VarAttrDef.VarAttr(name = SKIP_CHECKING_ACID_VERSION_FILE, needForward =
true, affectQueryResultInPlan = true,
- description = "Skip checking transactional hive version file
'_orc_acid_version.'"
- )
- public boolean skipCheckingAcidVersionFile = false;
Review Comment:
Fixed in e0ab4f990d38fd8b735eee6468be2102abae897f. Added
`skip_checking_acid_version_file` to the existing removed-variable
compatibility set: legacy session initialization accepts SET as a no-op, and
both variable-read paths retain the empty-string fallback. The session field
stays removed and Hive transactional reads remain rejected.
Added regression coverage for true/false values, case-insensitive names,
primary/follower SET handling, both read paths, and exclusion from exported
session variables. The new test reproduced the unknown-variable failure before
the fix. All 8 focused compatibility, variable-export and unsupported-read
tests pass after the fix; FE Checkstyle and clang-format 16 also pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
