github-actions[bot] commented on code in PR #69601:
URL: https://github.com/apache/doris/pull/69601#discussion_r4373671401
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -3509,11 +3507,6 @@ public void setDetailShapePlanNodes(String
detailShapePlanNodes) {
+ "non-utf8 characters will be displayed as garbled characters.")
public boolean enableTextValidateUtf8 = true;
- @VarAttrDef.VarAttr(name = SKIP_CHECKING_ACID_VERSION_FILE, needForward =
true, affectQueryResultInPlan = true,
- description = "Skip checking transactional hive version file
'_orc_acid_version.'"
- )
- public boolean skipCheckingAcidVersionFile = false;
Review Comment:
[P2] Keep the removed ACID session variable as a compatibility no-op
Deleting this field also removes `skip_checking_acid_version_file` from
VariableMgr's reflection-built registry, but the name is missing from
`REMOVED_SESSION_VAR_NAMES`. Existing scripts or JDBC connection initialization
that execute `SET skip_checking_acid_version_file = true` now get
`ERR_UNKNOWN_SYSTEM_VARIABLE`, preventing even unrelated supported queries from
starting; `SELECT @@skip_checking_acid_version_file` also loses the existing
removed-variable fallback. Add the old name to VariableMgr's removed-variable
set so clients can keep initializing sessions while Hive transactional reads
remain rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
