jacktengg commented on PR #69304:
URL: https://github.com/apache/doris/pull/69304#issuecomment-6278987112
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69304
commit: 2998a3acc3f3ebdcdb04206427424512c0b67eb6
base: 811de72f3fbf7fea03788b3744ce15ccd7dce0b5
reviewed_at: 2026-10-20T06:43+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/exprs/aggregate/aggregate_function_legacy_nullable.h:99-102` —
Re-reviewed the full 78-file PR at this head. Prior foreach preparation,
fixed-width append and compound-duration findings are fixed; all 21 prior
dismissals were re-confirmed.
- `docs/nullable-aggregation-v2-migration.md:128-142` — Keep version19 until
all executing, reading and compacting BEs are upgraded. Version20 bitmap
markers can enter old schemas; a session setting cannot downgrade persisted
markers or metadata.
- `docs/performance/nullable-aggregation/README.md:48-109` — Raw evidence
and regenerated statistics were independently checked. Final weighted50 query
peak remains higher than nearby warmed old measurements; attribution is
explicitly inference. No fresh build/test/cluster run or independent
source-to-binary/ELF proof was performed in this review.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
