jacktengg commented on PR #69304:
URL: https://github.com/apache/doris/pull/69304#issuecomment-6278436436
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69304
commit: 1ab6fe72ce8261681460af6c5931346642649739
base: 811de72f3fbf7fea03788b3744ce15ccd7dce0b5
reviewed_at: 2026-10-20T06:07+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 3, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/exprs/aggregate/aggregate_function_legacy_nullable.h:95` — Minor:
preserve foreach batch preparation in the byte-codec streaming adapter; shifted
visible array offsets otherwise allocate cut columns per row. Results remain
correct; no measured query slowdown is asserted.
- `be/src/exprs/aggregate/aggregate_function_null_v2.h:343` — Minor: the new
per-row native append reaches a wrong byte offset in
`aggregate_function_uniq_distribute_key.h:257`; use UInt64 indexing and cover
mixed-NULL streaming. This registered BE function has no FE SQL implementation
at this head.
- `docs/performance/nullable-aggregation/summarize_operators.py:32` — Minor:
parse complete compound durations and regenerate operator tables; `1sec153ms`
currently becomes 1000 ms. Query and kernel numeric summaries are unaffected.
- All 71 changed files covered; 1 converged round, no Blocker/Major.
Read-only review inspected archived ASAN/regression, mixed-BE and
full-compaction evidence; no build, tests or cluster operations were run. Keep
execution version 19 until all executing/reading/compacting BEs support 20, as
documented.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
