mrhhsg commented on PR #68279:
URL: https://github.com/apache/doris/pull/68279#issuecomment-6278571635
<!-- autopilot-response -->
Re-checked the full review history at HEAD
`ef01c98e4dcfe07e279fde164037bf539e476dc6` (identical to the PR head).
**New top-level comments since the previous report (neither contains a code
finding):**
- `IC_kwDOBfSlxs8AAAABdgW9YQ` — `run beut` trigger; the BE unit tests in
this area pass locally (see validation below).
- `IC_kwDOBfSlxs8AAAABdjiAOA` — BE regression/UT coverage report for this
HEAD; informational.
**Previous inline findings — fixed; both threads are resolved and outdated:**
- Sparse-accounting overcount in `segment_iterator.cpp`:
`_count_alive_rows()` (`be/src/storage/segment/segment_iterator.cpp:1162`)
charges each stage only for rows still set in `_row_bitmap`, using
`roaring_bitmap_range_cardinality`; `DisjointKeyRangesOnlyCountAliveRows`
(`be/test/storage/segment/segment_iterator_key_range_stats_test.cpp:204`)
asserts `RowsStatsFiltered == 1` for the disjoint key ranges `{1}` and `{5000}`.
- Trailing `DROP TABLE` in `point_lookup_zone_map_profile.groovy`: removed;
both tables are dropped only before creation (lines 21 and 161).
**Latest automated review:** the `github-actions` review at this exact HEAD
(2026-10-19T14:50:49Z) reports no new substantiated issue and states that no
previously reported blocking finding remains applicable.
**Validation at this HEAD (fresh local run):** `./run-be-ut.sh --run
--filter='SegmentIteratorKeyRangeStatsTest.*:SegmentIteratorExprZonemapTest.*'`
— 31 tests from 2 suites, all passed.
The `CHANGES_REQUESTED` decision dates from the 2026-09-20 automated review;
the author cannot dismiss it. Could a maintainer take another look and clear it
if the remaining concerns are satisfied?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
