mrhhsg commented on PR #68279:
URL: https://github.com/apache/doris/pull/68279#issuecomment-6274588245
<!-- autopilot-response -->
Re-checked the full review history at HEAD
`ef01c98e4dcfe07e279fde164037bf539e476dc6`.
**New top-level comment since the previous report:**
`IC_kwDOBfSlxs8AAAABdf2LEA` is a TPC-H benchmark payload for this commit; it
contains no code finding. The `run buildall` entry is a build trigger. No other
new comments.
**Previous inline findings — fixed; both threads are resolved and outdated:**
- Sparse-accounting overcount in `segment_iterator.cpp`:
`_count_alive_rows()` now uses `roaring_bitmap_range_cardinality` over the
surviving `_row_bitmap` (`be/src/storage/segment/segment_iterator.cpp:1162`),
and `DisjointKeyRangesOnlyCountAliveRows`
(`be/test/storage/segment/segment_iterator_key_range_stats_test.cpp:204`)
asserts `RowsStatsFiltered == 1` for disjoint key ranges `{1}` and `{5000}`.
- Trailing `DROP TABLE` in `point_lookup_zone_map_profile.groovy`: removed;
both tables are dropped only before creation (lines 21 and 161).
**Latest automated review:** the `github-actions` review at this exact HEAD
(2026-10-19T14:50:49Z) reports no new substantiated issue and states that no
previously reported blocking finding remains applicable.
**Validation at this HEAD (fresh local run):**
`SegmentIteratorKeyRangeStatsTest.*` and `SegmentIteratorExprZonemapTest.*` —
31 tests, all passed.
The current `CHANGES_REQUESTED` decision dates from the 2026-09-20 automated
review; the author cannot dismiss it. Could a maintainer take another look and
clear it if the remaining concerns are satisfied?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
