yiguolei commented on code in PR #69070:
URL: https://github.com/apache/doris/pull/69070#discussion_r4312628617
##########
be/src/storage/segment/page_builder.h:
##########
@@ -93,8 +88,26 @@ class PageBuilder {
virtual uint64_t get_raw_data_size() const = 0;
};
-template <typename Derived>
-class PageBuilderHelper : public PageBuilder {
+// A builder whose cells are fixed width: its FieldType's stored values.
+template <FieldType Type>
+ requires(!std::is_same_v<typename CppTypeTraits<Type>::CppType, Slice>)
+class FixedWidthPageBuilder : public PageBuilder {
+public:
+ // Appends up to *count cells, already stored values; *count becomes how
many went
+ // in, fewer than offered only when the page is full.
+ virtual Status add_cells(const typename CppTypeTraits<Type>::CppType*
cells, size_t* count) = 0;
+};
+
+// A builder whose cells are Slices.
+class StringPageBuilder : public PageBuilder {
Review Comment:
rename to 变长page builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
