yiguolei commented on code in PR #69070:
URL: https://github.com/apache/doris/pull/69070#discussion_r4312843874


##########
be/src/core/column/column_nullable.cpp:
##########
@@ -743,4 +743,14 @@ ColumnPtr remove_nullable(const ColumnPtr& column) {
     return column;
 }
 
+const IColumn& peel_nullable(const IColumn& column, size_t row_pos, const 
uint8_t** null_map) {

Review Comment:
   This method is not very common。
   Mostly this method is used by index writers. I think this method can be move 
to IndexWriter as a static method.
   Add comment and some examples.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to