mrhhsg commented on PR #69288: URL: https://github.com/apache/doris/pull/69288#issuecomment-6267402068
<!-- autopilot-response --> Reviewed the current review state of this PR (head `be394b4675c2df72f939406ee66e724d52b195c2`). - `IC_kwDOBfSlxs8AAAABdY8YwQ` (contribution checklist prompt): the PR description already covers all five requested points. Problem and root cause: in `FunctionJsonbModify::write_json_value`, the "last parent, member not present" object branch opened an extra object that the `JsonbWriter` state machine rejected (return value ignored) and then closed the already-open object early, so the caller's remaining `writeKey` / `writeValue` calls failed silently and the following sibling members disappeared. Fix: drop the extra `writeStartObject()` / `writeEndObject()` pair and append the new member directly to the already-open object; the existing paired `writeEndObject()` closes it normally. Behavior impact: `JSON_SET` / `JSON_INSERT` now keep the members that follow a nested object; top-level inserts, inserts into an object inside an array, `JSON_REPLACE` and `JSON_REMOVE` are unchanged. No new feature was added, and no other code was refactored. - `IC_kwDOBfSlxs8AAAABdY8eBA` (`/review`): this is the review trigger comment. The `Code Review` workflow for this head is still queued and has not produced findings yet, so there is nothing to fix from this comment. There are no unresolved inline review threads on this PR. No code changes were made in this round and the branch head is unchanged. Could a human reviewer take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
