Gabriel39 opened a new pull request, #69124:
URL: https://github.com/apache/doris/pull/69124
### What problem does this PR solve?
Related PR: #68707
The Unicode Lance branch fixture introduced by #68707 tracks five files
below `tree/devᲉ/`. This causes checkout failures on filesystems that cannot
represent that directory name.
Store these files under the ASCII directory `tree/dev_u1c89/` and restore
the original Unicode object prefix when uploading fixtures to MinIO. The
fixture payloads remain byte-for-byte identical, and the existing Unicode
branch regression coverage is preserved. Update the fixture checker and
regeneration instructions to use the portable Git layout. Initialization exits
on upload or relocation failure instead of continuing with an incomplete
fixture.
### Release note
None
### Check List (For Author)
- Test
- [x] Manual test (details below)
- Behavior changed:
- [x] No. Runtime fixture paths and contents are unchanged.
- Does this need documentation?
- [x] No. Fixture regeneration instructions are updated inline.
Validation:
1. Scanned all tracked paths: no non-ASCII names or literal backslashes
remain. Checked out all 10 files in the Unicode fixture using a fresh Git index
with `core.protectNTFS=true` and `core.protectHFS=true` on Linux.
2. Ran `lance_build_unicode_branch.py --check` on the renamed fixture with
pylance 12.0.0.
3. Executed the upload commands extracted from `iceberg.yaml.tpl` against a
temporary MinIO instance with the pinned mc image. Ran initialization twice,
injecting a stale object before the second run. After each run, all 515 object
keys and blob hashes matched the original fixtures exactly; neither the ASCII
alias nor the stale object remained.
4. Read the main snapshot and both Unicode branch versions with pylance
12.0.0. Confirmed 8 rows in branch version 1, 12 rows in version 2, and vector
search returning the expected branch-only rows.
5. Passed YAML parsing, shell syntax validation, and `git diff --check`.
Full Doris regression tests and a native Windows checkout were not run
locally.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
