Gabriel39 opened a new pull request, #69123:
URL: https://github.com/apache/doris/pull/69123
### What problem does this PR solve?
Related PR: #68865
On `branch-4.1`, a session time zone of `+00:00` or `-00:00` is
canonicalized by Java to `Z`. ORC treats that value as a zoneinfo filename, so
reading an ORC file fails with `Can't open /usr/share/zoneinfo/Z`.
Adapt the zero-offset normalization from #68865 to the existing shared FE
helper: send `UTC` for fixed zero-offset zones while preserving nonzero
offsets, aliases, and regional historical/DST rules. All existing callers of
the helper receive the corrected identifier.
### Release note
Fix ORC reads failing when the session time zone is a zero offset such as
`+00:00`.
### Check List (For Author)
- Test
- [x] Unit Test
- [x] Manual test
Validation:
- Recompiled `TimeUtils` and `TimeUtilsTest` against prebuilt FE
dependencies and ran JUnitCore: all 10 tests passed. Before the fix, the new
zero-offset test failed with expected `UTC`, actual `Z`.
- Coverage includes standardized `+0:00`/`-0:00`, fixed zero-offset names,
nonzero fractional offsets, aliases, DST regions, and a region with historical
offset changes.
- FE Checkstyle: `mvn -B -pl fe-core -am checkstyle:check`.
- An isolated ORC library probe reproduced the `Z` failure and read the same
synthetic ORC file successfully with `UTC`.
- A full Doris build and SQL end-to-end regression were not run locally; CI
is requested separately.
- Behavior changed:
- [x] Yes. Fixed zero-offset zones are sent to execution backends as
`UTC`.
- Does this need documentation?
- [x] No.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
