morningman commented on code in PR #69086:
URL: https://github.com/apache/doris/pull/69086#discussion_r4279454653
##########
fe/fe-connector/fe-connector-spi/src/main/java/org/apache/doris/connector/spi/ConnectorTableDdlOps.java:
##########
@@ -82,4 +84,22 @@ default void truncateTable(ConnectorSession session,
throw new DorisConnectorException(
"TRUNCATE TABLE not supported");
}
+
+ /**
+ * Sets connector-native properties on the table identified by {@code
handle}, for
+ * {@code ALTER TABLE ... SET ("key" = "value", ...)}. A key in {@code
properties} is added or overwritten;
+ * a key not in it keeps its current value.
+ *
+ * <p>The map is one change: the connector must commit every entry or none
of them. A statement that
+ * fails after committing part of the map would leave the table in a state
the user never asked for.
+ * Properties Doris owns itself, such as {@code auto_analyze_policy},
never reach this method.</p>
+ *
+ * @throws DorisConnectorException if the connector does not support it,
or the remote catalog rejects
+ * the change
+ */
+ default void setTableProperties(ConnectorSession session,
+ ConnectorTableHandle handle, Map<String, String> properties) {
Review Comment:
Not bumping here, on purpose, as on #68874 and #68901. The connector SPI has
not shipped in a release: the FE and every connector plugin are built from the
same tree and released together, so no released FE serves 13.0 without
`setTableProperties`, and pairing plugin jars with an FE from another commit is
not a supported installation. Until the SPI ships, methods are added without
moving `connector.plugin.api.version`. The new method is recorded in the
metadata-method baseline (`connector-metadata-methods.txt`) in this PR, so the
surface test still pins it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
