github-actions[bot] commented on code in PR #69086:
URL: https://github.com/apache/doris/pull/69086#discussion_r4275521155
##########
fe/fe-connector/fe-connector-spi/src/main/java/org/apache/doris/connector/spi/ConnectorTableDdlOps.java:
##########
@@ -82,4 +84,22 @@ default void truncateTable(ConnectorSession session,
throw new DorisConnectorException(
"TRUNCATE TABLE not supported");
}
+
+ /**
+ * Sets connector-native properties on the table identified by {@code
handle}, for
+ * {@code ALTER TABLE ... SET ("key" = "value", ...)}. A key in {@code
properties} is added or overwritten;
+ * a key not in it keeps its current value.
+ *
+ * <p>The map is one change: the connector must commit every entry or none
of them. A statement that
+ * fails after committing part of the map would leave the table in a state
the user never asked for.
+ * Properties Doris owns itself, such as {@code auto_analyze_policy},
never reach this method.</p>
+ *
+ * @throws DorisConnectorException if the connector does not support it,
or the remote catalog rejects
+ * the change
+ */
+ default void setTableProperties(ConnectorSession session,
+ ConnectorTableHandle handle, Map<String, String> properties) {
Review Comment:
[P2] Bump the connector API major for the new SPI method
This adds a public connector SPI method while `connector.plugin.api.version`
and the version pinned in `ConnectorPluginSurfaceTest` remain `13.0`. The
loader compares only majors and loads SPI classes from the FE, so a plugin
compiled to call this new method is still admitted by an older 13.0 FE whose
SPI does not provide it; that call can then fail with `NoSuchMethodError`
instead of a version-gate rejection. The version contract in
`fe-connector/AGENTS.md` and the parent POM explicitly treats additions as a
major change. Please bump the API major and update the pinned version in this
PR. The second surface renderer does not include metadata methods, so its
unchanged baseline does not remove the need for that bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
