OIiveirra commented on PR #68811: URL: https://github.com/apache/doris/pull/68811#issuecomment-6123859701
@924060929 Thanks for pointing out these two non-blocking logging regressions in https://github.com/apache/doris/pull/68811#issuecomment-6121809195. Both are addressed in f98cd864eb2: 1. Restored Throwable logging in the non-diagnostic fallback branches of `ExternalCatalog` and `CatalogIf`, including initialization, database listing/lookup, and existence checks. Exceptions carrying a diagnostic policy continue to use the sanitized trace. The existing catch/return behavior is unchanged. 2. JDBC data-source cleanup failures now log exception class names and stack locations throughout the cause chain, without rendering exception messages. Cleanup can fail outside an individual pool, so this uses the suggested message-free fallback rather than guessing credentials or restoring the raw Throwable. Cause cycles are handled. Validation: the standard personal `run-fe-ut.sh` wrapper ran `JdbcCatalogDiagnosticsTest` and `JdbcDiagnosticsTest` with JDK 17: 13 tests passed, 0 failures/errors/skips; Maven Checkstyle and the build passed. The added tests capture the actual catalog log (including the swallowed exception's cause trace) and check that cleanup diagnostics retain types/locations without passwords or JDBC URLs. This commit addresses the two non-blocking logging regressions above; it does not claim to resolve the separate statement/job final-output-boundary comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
