github-actions[bot] commented on code in PR #68593: URL: https://github.com/apache/doris/pull/68593#discussion_r4131392790
########## contrib/apache-orc: ########## @@ -1 +1 @@ -Subproject commit be0f1b73a7aeb78824a03e0dcb692c50a176d513 Review Comment: [P2] Link libdeflate from ORC's own targets on ARM. This revision makes `ZlibDecompressionStreamByLibDeflate` unconditional, so `liborc.a` now references `libdeflate_*` on ARM. The submodule's `orc` target still links only protobuf, zlib, snappy, lz4, zstd, and HDFS; `orc-test` and tools such as `orc-contents` link through that target without libdeflate. Building those targets on ARM therefore fails with undefined libdeflate symbols. Doris's `COMMON_THIRDPARTY` link group covers `doris_be`, not these executables. Please declare libdeflate on the ORC target and update this submodule pointer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
