Gabriel39 commented on PR #68593: URL: https://github.com/apache/doris/pull/68593#issuecomment-5892167650
Reviewed head `3b7ad3b3ec0c4efbbf4781008b63301b64230464`. The empty/short GZIP output checks and the lazy ORC scratch-buffer allocation address the earlier correctness and memory concerns. One build dependency issue remains, also noted in the [existing inline comment](https://github.com/apache/doris/pull/68593#discussion_r4131392790): **ORC's own target does not declare its libdeflate dependency.** The pinned ORC revision now calls `libdeflate_*` unconditionally, including on ARM64, but its [`target_link_libraries(orc ...)`](https://github.com/apache/doris-thirdparty/blob/5860f94768b94406f31698ac66f4cc3d2a781324/c%2B%2B/src/CMakeLists.txt#L200-L210) still lists only protobuf, zlib, snappy, lz4, zstd, and HDFS libraries. ORC executables such as `orc-test`, `orc-contents`, and `orc-scan` link through that target and do not add libdeflate themselves. Building those targets on ARM64 without manually supplying additional linker flags will therefore leave unresolved `libdeflate_*` symbols. Doris's final BE link includes libdeflate through `COMMON_THIRDPARTY`, so a passing BE build does not validate these separate ORC targets. The dependency omission already affected the x86 libdeflate path; this change extends it to ARM64. Please declare libdeflate as a transitive dependency of the ORC target, ensure the standalone build can discover its headers/library, and update the submodule pointer. Validate an ORC test/tool executable as well as the Doris BE build on ARM64. This conclusion is based on source and CMake inspection. I did not run an ARM64 build or reproduce the linker failure locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
