924060929 commented on code in PR #68196:
URL: https://github.com/apache/doris/pull/68196#discussion_r4130203293
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalCatalog.java:
##########
@@ -1247,10 +1320,49 @@ public void unregisterDatabase(String dbName) {
if (LOG.isDebugEnabled()) {
LOG.debug("unregister database [{}]", dbName);
}
- if (isInitialized()) {
- metaCache.invalidate(dbName, Util.genIdByName(name, dbName));
Review Comment:
Fixed in 182ef43447a. A no-op DROP now scans only retained cached identities
matching the requested name (respecting the database case mode), and the
built-in connectors use that narrow cleanup instead of routing through
unregisterDatabase on an unresolved name. A missing target therefore leaves an
unrelated hot DB and its row counts untouched. CatalogMgrTest and MetaCacheTest
cover the absent target, retained historical alias, and case-sensitive mode;
the 176 focused FE tests and full FE build pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
