lets-order-some-fries opened a new pull request, #68395:
URL: https://github.com/apache/doris/pull/68395
### What problem does this PR solve?
Related PR: #67338
Problem Summary:
#67338 marked `tls_private_key_password` and `key_store_password` as
`@ConfField(sensitive = true)`, so both are now masked by
`ConfigBase.dump()` and by
`ConfigBase.getConfigInfo()`. Nothing tests it.
The two neighbouring secrets in the same file do have that coverage —
`testSensitiveConfigIsMaskedWhenSet` for `fe_meta_auth_token` and
`testAuthTokenIsMaskedWhenSet`
for `auth_token` — so this is a gap in an otherwise tested property rather
than a new one. Both of
these configs are operator-supplied secrets in `fe.conf`, and the annotation
is the only thing
keeping them out of every config dump API; dropping it while editing a
neighbouring line would be
silent today.
This PR adds only the missing test case. No production code changes.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
---
Run locally against `master` at `f5da8fb1`:
- `mvn -pl fe-common test -Dtest=ConfigTest` — **Tests run: 11, Failures: 0,
Errors: 0**
- `mvn -pl fe-common checkstyle:check` — **0 violations**
And proved the test is not vacuous: removing `sensitive = true` from
`key_store_password` makes it
fail with `expected: <********> but was: <super-secret-key-store-password>`;
restoring it passes.
This supersedes my #67007, which proposed the same annotations before #67338
landed them. I'm
closing that one — only the test was still missing, and it's here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
