lets-order-some-fries commented on PR #67238: URL: https://github.com/apache/doris/pull/67238#issuecomment-5778600086
A status note, since this PR currently reads as "changes requested" and that signal is stale. The `/review` finding from 28 Aug was a real regression and is fixed. `doMatchTypes` accumulated the timezone preference with `++`/`--` across arguments, so one zoned literal mixed with zone-less ones could still win on the summed score. The fix was `66e0ff14`; after a rebase onto master on 15 Sep it is now **`a6591567`**, the current head. The blocking review predates both commits, so nothing has re-evaluated the branch as it stands. Re-verified today on `a6591567`: - `mvn -pl fe-core checkstyle:check` — **0 violations** (CI's own command) - no conflicts against master As on my other FE PR, I can't compile the FE locally — this is macOS arm64 and the prebuilt thirdparty is a release behind the thrift version `fe/pom.xml` now asks for — so `run buildall` would be the first compile of the rebased branch, and I'd rather say that plainly than have CI time spent on a surprise. @morrySnow you triggered buildall here on 28 Aug — would you re-run `/review` so the stale blocking review is replaced, or trigger `run buildall`? If either turns up something new I'll fix it the same day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
