github-actions[bot] commented on code in PR #66913:
URL: https://github.com/apache/doris/pull/66913#discussion_r4061443745
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -1674,7 +1686,10 @@ public void startSplit(int numBackends) throws
UserException {
Review Comment:
[P1] Retain the frozen generation used by this scan
An MTMV refresh can install its outer task's G1 snapshot in a fresh
execution statement, but after a reset `source.getIcebergTable()` first
registers current G2 and `useFrozenTableGeneration()` only then swaps the scan
table/runtime back to G1. A batch scan therefore retains G2 here while
`planFiles()` runs on G1. If cancellation or failure returns the task before an
interrupt-ignoring planner exits, `TaskProcessor` closes the outer G1 owner and
G1's FileIO/executor can be retired underneath that worker even though this G2
lease remains alive. Please carry/retain the exact frozen generation into
`AsyncPlanningTask`, and cover an injected G1/current G2 MTMV scan with reset
plus cancellation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
