924060929 commented on code in PR #66913:
URL: https://github.com/apache/doris/pull/66913#discussion_r4059258971
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergMetadataOps.java:
##########
@@ -337,23 +330,23 @@ public void afterDropDb(String dbName) {
@Override
public boolean createTableImpl(CreateTableInfo createTableInfo) throws
UserException {
try {
- return executionAuthenticator.execute(() ->
performCreateTable(createTableInfo));
+ return executeCatalogOperation(() ->
performCreateTable(createTableInfo));
} catch (Exception e) {
throw new DdlException(
"Failed to create table: " + createTableInfo.getTableName() +
", error message is:" + e.getMessage(),
e);
}
}
- public boolean performCreateTable(CreateTableInfo createTableInfo) throws
UserException {
+ private boolean performCreateTable(CreateTableInfo createTableInfo) throws
UserException {
String dbName = createTableInfo.getDbName();
- ExternalDatabase<?> db = dorisCatalog.getDbNullable(dbName);
+ ExternalDatabase<?> db = getDatabaseWithinCatalogGeneration(dbName);
Review Comment:
Fixed in 5f715eca4bd.
The case-fold collision check now stays on the Iceberg catalog generation
retained by the CREATE TABLE operation. For lower_case_table_names modes 1/2 it
enumerates names through the retained Iceberg catalog instead of calling
ExternalDatabase.getTableNullable(), which could reinitialize and observe a
newer generation after reset. Mode 0 keeps the exact-name path without extra
enumeration.
Added native and HMS reset-barrier tests proving the operation still checks
G1 after retirement, does not touch the mutable Doris database cache, and
delays G1 cleanup until the operation guard exits.
Validation:
- IcebergMetadataOpTest: 12 tests, 0 failures/errors
- FE Checkstyle: 0 violations
- ./build.sh --fe -j4: BUILD SUCCESS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
