yiguolei commented on code in PR #67341:
URL: https://github.com/apache/doris/pull/67341#discussion_r3900217459


##########
be/src/storage/index/zone_map/zone_map_index.cpp:
##########
@@ -54,6 +54,18 @@ Status ZoneMap::from_proto(const ZoneMapPB& zone_map, const 
DataTypePtr& data_ty
     zone_map_info.has_positive_inf = zone_map.has_positive_inf();
     zone_map_info.has_nan = zone_map.has_nan();
 
+    // A bound that fails to parse makes the zone map invalid: mark it 
pass_all so it prunes
+    // nothing, instead of failing the scan that loads it.
+    auto parse_bound = [&](const std::string& bound, Field& value, const char* 
which) {
+        Status st = data_type->get_serde()->from_zonemap_string(bound, value);
+        if (!st.ok()) {
+            LOG_EVERY_N(WARNING, 100) << "unparsable zone map " << which << " 
'" << bound

Review Comment:
   别打了,如果文件很多,数据很大,可能打崩



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to