github-actions[bot] commented on code in PR #67341:
URL: https://github.com/apache/doris/pull/67341#discussion_r3893041314
##########
be/src/storage/segment/column_reader.cpp:
##########
@@ -477,6 +478,12 @@ Status ColumnReader::next_batch_of_zone_map(size_t* n,
MutableColumnPtr& dst) co
// TODO: this work to get min/max value seems should only do once
ZoneMap zone_map;
RETURN_IF_ERROR(ZoneMap::from_proto(*_segment_zone_map, _data_type,
zone_map));
Review Comment:
`pass_all` is the state this PR uses for legacy bounds such as the old
DBL_MAX rendering, but this branch turns it back into a query error.
`Segment::new_iterator` still selects `VStatisticsIterator` for MINMAX when
delete predicates are empty, and `VStatisticsIterator::next_batch` propagates
this status, so MIN/MAX over an otherwise readable old segment fails instead of
scanning conservatively. Please disable the statistics fast path or fall back
to a normal `SegmentIterator` when the segment zone map is unusable, and add a
regression covering the MINMAX path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
