nishant94 commented on code in PR #64667: URL: https://github.com/apache/doris/pull/64667#discussion_r3755112400
########## be/src/storage/index/inverted/analyzer/kuromoji/kuromoji_normalize.h: ########## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstdint> +#include <string> +#include <string_view> + +namespace doris::segment_v2::inverted_index::kuromoji { + +// CJK width folding (a subset of Lucene's CJKWidthFilter): full-width ASCII +// variants U+FF01..U+FF5E -> basic-latin U+0021..U+007E, and the ideographic +// space U+3000 -> ' '. So ＡＢＣ１２３ -> ABC123. Everything else is preserved +// byte-for-byte. (Half-width katakana -> full-width composition is a TODO.) Review Comment: Real gap, and it's the TODO already noted in kuromoji_normalize.h. Correct fold requires the full Lucene CJKWidthFilter table applied before segmentation, including dakuten/handakuten composition (`ｶﾞ→ガ`) which changes code-point count, plus bidirectional index/query tests. A subtly-wrong composition table would be worse than the documented limitation on an opt-in analyzer. imo we also don't need to change this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
