github-actions[bot] commented on code in PR #15925:
URL: https://github.com/apache/doris/pull/15925#discussion_r1070650460
##########
be/src/vec/common/string_ref.h:
##########
@@ -277,11 +383,12 @@ inline size_t hash_less_than16(const char* data, size_t
size) {
}
struct CRC32Hash {
- size_t operator()(StringRef x) const {
+ size_t operator()(const StringRef& x) const {
const char* pos = x.data;
size_t size = x.size;
- if (size == 0) return 0;
+ if (size == 0)
+ return 0;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (size == 0) {
return 0;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
