github-actions[bot] commented on code in PR #15925:
URL: https://github.com/apache/doris/pull/15925#discussion_r1070270915
##########
be/src/olap/like_column_predicate.h:
##########
@@ -48,7 +48,12 @@ class LikeColumnPredicate : public ColumnPredicate {
bool* flags) const override;
std::string get_search_str() const override {
- return std::string(reinterpret_cast<char*>(pattern.ptr), pattern.len);
+ if constexpr (std::is_same_v<PatternType, StringRef>)
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if constexpr (std::is_same_v<PatternType, StringRef>) {
```
be/src/olap/like_column_predicate.h:52:
```diff
- else if constexpr (std::is_same_v<PatternType, StringVal>) {
+ } else if constexpr (std::is_same_v<PatternType, StringVal>) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
