yujun777 commented on code in PR #65657:
URL: https://github.com/apache/doris/pull/65657#discussion_r3628166723
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -276,11 +276,11 @@ public LogicalOlapTableStreamScan
withSelectedPartitionIds(List<Long> selectedPa
*/
@Override
public LogicalOlapTableStreamScan withSelectedPartitionIds(List<Long>
selectedPartitionIds,
- boolean
isPartitionPruned) {
+ boolean
hasPartitionPredicate) {
return AbstractPlan.copyWithSameId(this, () ->
new LogicalOlapTableStreamScan(relationId, (Table) table,
qualifier,
groupExpression, Optional.of(getLogicalProperties()),
- selectedPartitionIds, isPartitionPruned,
hasPartitionPredicate, selectedTabletIds,
+ selectedPartitionIds, true, hasPartitionPredicate,
selectedTabletIds,
Review Comment:
Following up on this inline thread: the reported
NormalizeOlapTableStreamScan/block-rule behavior is pre-existing and is not
changed by this PR. Normalize is expected to create executable LogicalOlapScan
children with the internally selected partitions. This PR only changes
LogicalOlapTableStreamScan.withSelectedPartitionIds() so its boolean follows
the parent contract and the stream scan is marked partition-pruned. Please do
not treat the unrelated normalization/block-rule semantics as a blocker for
this PR; if that behavior needs to change, it should be handled in a separate
issue/PR with an end-to-end reproduction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
