yujun777 commented on code in PR #65657:
URL: https://github.com/apache/doris/pull/65657#discussion_r3628175102
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -276,11 +276,11 @@ public LogicalOlapTableStreamScan
withSelectedPartitionIds(List<Long> selectedPa
*/
@Override
public LogicalOlapTableStreamScan withSelectedPartitionIds(List<Long>
selectedPartitionIds,
- boolean
isPartitionPruned) {
+ boolean
hasPartitionPredicate) {
return AbstractPlan.copyWithSameId(this, () ->
new LogicalOlapTableStreamScan(relationId, (Table) table,
qualifier,
groupExpression, Optional.of(getLogicalProperties()),
- selectedPartitionIds, isPartitionPruned,
hasPartitionPredicate, selectedTabletIds,
+ selectedPartitionIds, true, hasPartitionPredicate,
selectedTabletIds,
Review Comment:
Response to the Request changes review: the review correctly describes the
local builder-contract fix, but the remaining NormalizeOlapTableStreamScan
behavior is not introduced or modified by this PR. Lowering a stream into
executable LogicalOlapScan base/binlog children with internally selected
partitions is existing and required behavior. The review assumes that these
internal selected partitions must not satisfy the existing
hasPartitionPredicate/block-rule semantics; that is a separate semantic change,
not a correctness regression caused by this patch. The requested changes to
PruneEmptyPartition, normalized-child construction, and end-to-end
SqlBlockRuleMgr coverage would therefore expand the scope beyond the two-line
production fix. The current test intentionally validates the builder contract
that fixes the repeated PruneOlapScanPartition rewrite. Please treat the
Normalize/block-rule behavior as a separate issue/PR with a concrete end-to-end
reproduction, rather than block
ing this PR.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -276,11 +276,11 @@ public LogicalOlapTableStreamScan
withSelectedPartitionIds(List<Long> selectedPa
*/
@Override
public LogicalOlapTableStreamScan withSelectedPartitionIds(List<Long>
selectedPartitionIds,
- boolean
isPartitionPruned) {
+ boolean
hasPartitionPredicate) {
return AbstractPlan.copyWithSameId(this, () ->
new LogicalOlapTableStreamScan(relationId, (Table) table,
qualifier,
groupExpression, Optional.of(getLogicalProperties()),
- selectedPartitionIds, isPartitionPruned,
hasPartitionPredicate, selectedTabletIds,
+ selectedPartitionIds, true, hasPartitionPredicate,
selectedTabletIds,
Review Comment:
Regarding the blocking conclusion in this review:
NormalizeOlapTableStreamScan creating executable LogicalOlapScan children is
existing and expected behavior, and it is unchanged by this PR. The scope of
this PR is limited to fixing the boolean contract in
LogicalOlapTableStreamScan.withSelectedPartitionIds() and marking the stream
scan as partition-pruned. The proposed normalization/block-rule semantic change
is therefore unrelated to this patch and should be tracked separately with an
end-to-end reproduction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
