github-actions[bot] commented on code in PR #63860:
URL: https://github.com/apache/doris/pull/63860#discussion_r3563146393
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -6678,10 +6678,15 @@ public LogicalPlan
visitShowTypeCast(DorisParser.ShowTypeCastContext ctx) {
@Override
public LogicalPlan visitShowTrash(ShowTrashContext ctx) {
if (ctx.ON() != null) {
- String backend = stripQuotes(ctx.STRING_LITERAL().getText());
- new ShowTrashCommand(backend);
- } else {
- return new ShowTrashCommand();
+ List<String> backendsQuery = Lists.newArrayList();
+ // Handle new added grammar: ON ("host:port", ...)
+ if (ctx.backends != null && !ctx.backends.isEmpty()) {
Review Comment:
The current head still has a failing `check_coverage_fe` status, and the
public FE increment report for `adc6874` shows only `78.95% (15/19)`
incremental FE coverage. The missed/partial lines are the new branch lines in
this SHOW TRASH path: `LogicalPlanBuilder` is `66.67% (4/6)` because this
defensive `ctx.backends != null && !ctx.backends.isEmpty()` / `else if
(ctx.backend != null)` shape creates parse-context branches that normal SQL
cannot cover, while `ShowTrashCommand` is `84.62% (11/13)` because the
no-filter and non-matching-backend branches are not covered by the new unit
test.
Since the grammar already guarantees that `ON` is either a non-empty
parenthesized backend list or the legacy single backend literal, please
simplify the parser branch to those two real shapes (asserting the invariant if
needed) and add command tests for `new ShowTrashCommand()` and an unmatched
backend list so the coverage gate is green on the current patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
