github-actions[bot] commented on code in PR #63860:
URL: https://github.com/apache/doris/pull/63860#discussion_r3556169088
##########
fe/fe-sql-parser/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -464,7 +464,8 @@ supportedShowStatement
| SHOW FULL? (COLUMNS | FIELDS) (FROM | IN) tableName=multipartIdentifier
((FROM | IN) database=multipartIdentifier)? wildWhere?
#showColumns
| SHOW TABLE tableId=INTEGER_VALUE
#showTableId
- | SHOW TRASH (ON backend=STRING_LITERAL)?
#showTrash
+ | SHOW TRASH (ON LEFT_PAREN backends+=STRING_LITERAL
Review Comment:
This changes more than the backend filter cardinality: it removes the
existing `SHOW TRASH ON "host:port"` syntax. The base grammar accepted `ON
backend=STRING_LITERAL`, and the old regression exercised `show trash on
"127.0.0.1:9050";`; with this rule the same statement now fails to parse, and
the new parser test explicitly asserts that failure. Even if the new list form
should match `ADMIN CLEAN TRASH ON`, please keep the legacy single-literal
alternative and map it to a one-element backend list while adding the
parenthesized multi-backend form, so existing scripts do not break on upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
