github-actions[bot] commented on code in PR #15624:
URL: https://github.com/apache/doris/pull/15624#discussion_r1064358952
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -88,31 +103,31 @@
vectorized::Block block2({type_and_name2});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_writer(batch_size, spill_block_writer,
profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -88,31 +103,31 @@
vectorized::Block block2({type_and_name2});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
spill_block_writer->write(block1);
spill_block_writer->write(block2);
spill_block_writer->close();
vectorized::BlockSpillReaderUPtr spill_block_reader;
- block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader);
- bool eof = false;
- vectorized::Block block_read;
+ block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -55,14 +61,23 @@ class TestBlockSpill : public testing::Test {
std::vector<StorePath> paths;
paths.emplace_back(test_data_dir, -1);
block_spill_manager = std::make_shared<BlockSpillManager>(paths);
+ block_spill_manager->init();
}
static void TearDownTestSuite() { FileUtils::remove_all(test_data_dir); }
protected:
- void SetUp() {}
+ void SetUp() {
+ env_ = ExecEnv::GetInstance();
+ env_->_block_spill_mgr = block_spill_manager.get();
Review Comment:
warning: '_block_spill_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
env_->_block_spill_mgr = block_spill_manager.get();
^
```
**be/src/runtime/exec_env.h:278:** declared private here
```cpp
BlockSpillManager* _block_spill_mgr = nullptr;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -137,20 +152,20 @@
vectorized::Block block({type_and_name});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_writer(batch_size, spill_block_writer,
profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -237,22 +254,22 @@
vectorized::Block block({type_and_name});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Status st = spill_block_writer->write(block);
spill_block_writer->close();
EXPECT_TRUE(st.ok());
vectorized::BlockSpillReaderUPtr spill_block_reader;
- block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader);
- bool eof = false;
- vectorized::Block block_read;
+ block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -187,32 +203,33 @@
vectorized::Block block({test_string});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_writer(batch_size, spill_block_writer,
profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -187,32 +203,33 @@
vectorized::Block block({test_string});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Status st = spill_block_writer->write(block);
spill_block_writer->close();
EXPECT_TRUE(st.ok());
vectorized::BlockSpillReaderUPtr spill_block_reader;
- block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader);
- bool eof = false;
- vectorized::Block block_read;
+ block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -294,22 +312,22 @@
vectorized::Block block({test_decimal});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
auto st = spill_block_writer->write(block);
spill_block_writer->close();
EXPECT_TRUE(st.ok());
vectorized::BlockSpillReaderUPtr spill_block_reader;
- block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader);
- bool eof = false;
- vectorized::Block block_read;
+ block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -237,22 +254,22 @@
vectorized::Block block({type_and_name});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_writer(batch_size, spill_block_writer,
profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -349,22 +368,22 @@
vectorized::Block block({type_and_name});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_writer(batch_size, spill_block_writer,
profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -413,34 +433,35 @@
vectorized::Block block({type_and_name});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
auto st = spill_block_writer->write(block);
spill_block_writer->close();
EXPECT_TRUE(st.ok());
vectorized::BlockSpillReaderUPtr spill_block_reader;
- block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader);
- bool eof = false;
- vectorized::Block block_read;
+ block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -349,22 +368,22 @@
vectorized::Block block({type_and_name});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
auto st = spill_block_writer->write(block);
spill_block_writer->close();
EXPECT_TRUE(st.ok());
vectorized::BlockSpillReaderUPtr spill_block_reader;
- block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader);
- bool eof = false;
- vectorized::Block block_read;
+ block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -294,22 +312,22 @@
vectorized::Block block({test_decimal});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_writer(batch_size, spill_block_writer,
profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -137,20 +152,20 @@
vectorized::Block block({type_and_name});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
spill_block_writer->write(block);
spill_block_writer->close();
vectorized::BlockSpillReaderUPtr spill_block_reader;
- block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader);
- bool eof = false;
- vectorized::Block block_read;
+ block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_reader(spill_block_writer->get_id(),
spill_block_reader, profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -413,34 +433,35 @@
vectorized::Block block({type_and_name});
vectorized::BlockSpillWriterUPtr spill_block_writer;
- block_spill_manager->get_writer(batch_size, spill_block_writer);
+ block_spill_manager->get_writer(batch_size, spill_block_writer, profile_);
Review Comment:
warning: 'profile_' is a private member of 'doris::TestBlockSpill'
[clang-diagnostic-error]
```cpp
block_spill_manager->get_writer(batch_size, spill_block_writer,
profile_);
^
```
**be/test/vec/core/block_spill_test.cpp:79:** declared private here
```cpp
RuntimeProfile* profile_;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
