yiguolei commented on code in PR #15624: URL: https://github.com/apache/doris/pull/15624#discussion_r1064254237
########## be/src/runtime/runtime_state.h: ########## @@ -416,6 +416,18 @@ class RuntimeState { #endif } + static constexpr int64_t MIN_EXTERNAL_SORT_BYTES_THRESHOLD = 128 << 20; Review Comment: 这个参数检查放到FE里,不要再BE里检查了。 在FE 里检查有2个好处: 1. 用户可以直接看到报错信息,知道是否生效了,在BE 上相当于报错了,但是用户不知道。 2. fuzzy的时候,可以根据是否开启fuzzy模式,设置比较小的值就去触发spill to disk。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org