github-actions[bot] commented on code in PR #64886:
URL: https://github.com/apache/doris/pull/64886#discussion_r3510072875


##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/SuiteContext.groovy:
##########
@@ -314,6 +324,21 @@ class SuiteContext implements Closeable {
         return DriverManager.getConnection(hiveJdbcUrl, hiveJdbcUser, 
hiveJdbcPassword)
     }
 
+    Connection getConnectionBySparkIcebergConfig() {
+        Class.forName("org.apache.hive.jdbc.HiveDriver");
+        String sparkJdbcUser =  "hadoop"
+        String sparkJdbcPassword = "hadoop"
+        String sparkJdbcUrl = getSparkIcebergJdbcUrl()
+        log.info("Create Spark Iceberg JDBC connection to 
${sparkJdbcUrl}".toString())
+        return DriverManager.getConnection(sparkJdbcUrl, sparkJdbcUser, 
sparkJdbcPassword)
+    }
+
+    String getSparkIcebergJdbcUrl() {

Review Comment:
   This introduces a second, unsynchronized port knob. The Docker stack now 
publishes the Spark ThriftServer using `SPARK_THRIFT_PORT`, but the regression 
framework reads `iceberg_spark_thrift_port` here, and that key is not present 
in the checked-in regression configs next to `iceberg_rest_uri_port` / 
`iceberg_minio_port`. Any run that overrides `SPARK_THRIFT_PORT` to avoid a 
host-port conflict will start Spark on the new port while `spark_iceberg` / 
`spark_paimon` still connect to `externalEnvIp:11000`, so these new suites fail 
before executing SQL. Please add and wire the matching regression config key, 
or derive this URL from the same setting used by the compose env.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to