This is an automated email from the ASF dual-hosted git repository.
HappenLee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 53b3bcd4398 [chore](gensrc) Remove unused IDL structures (#65113)
53b3bcd4398 is described below
commit 53b3bcd4398667ea828d26d25b138d3374fb5983
Author: Pxl <[email protected]>
AuthorDate: Thu Jul 2 10:02:58 2026 +0800
[chore](gensrc) Remove unused IDL structures (#65113)
Several legacy thrift and protobuf structures are no longer referenced
by Doris code or active IDL entry points. Keeping them increases
generated IDL surface area and makes it harder to tell which
request/response formats are still live.
This change removes the unused runtime filter target thrift structure,
stale tablet-writer batch protobuf request/result messages, the unused
column-data-file protobuf, and now-unused protobuf helper messages.
Issue Number: None
Related PR: None
### Release note
None
### Check List (For Author)
- Test: Manual test
- `git diff --check`
- `DORIS_THIRDPARTY=/mnt/disk8/xiaolei/codespaces/doris/thirdparty make
-C gensrc`
- Verified no `TRuntimeFilterTargetParams` / `rid_to_target_param`
references remain outside generated outputs
- Behavior changed: No
- Does this need documentation: No
---
be/test/exec/pipeline/thrift_builder.h | 2 -
gensrc/proto/column_data_file.proto | 68 --------------------------------
gensrc/proto/internal_service.proto | 40 -------------------
gensrc/proto/olap_common.proto | 32 ---------------
gensrc/thrift/PaloInternalService.thrift | 11 ------
5 files changed, 153 deletions(-)
diff --git a/be/test/exec/pipeline/thrift_builder.h
b/be/test/exec/pipeline/thrift_builder.h
index 8868d456a3d..8bf04afe004 100644
--- a/be/test/exec/pipeline/thrift_builder.h
+++ b/be/test/exec/pipeline/thrift_builder.h
@@ -427,12 +427,10 @@ class TRuntimeFilterParamsBuilder {
public:
explicit TRuntimeFilterParamsBuilder(
TNetworkAddress runtime_filter_merge_addr = TNetworkAddress(),
- std::map<int, std::vector<TRuntimeFilterTargetParams>>
rid_to_target_param = {},
std::map<int, int> runtime_filter_builder_num = {},
std::map<int, std::vector<TRuntimeFilterTargetParamsV2>>
rid_to_target_paramv2 = {})
: _params() {
_params.__set_runtime_filter_merge_addr(runtime_filter_merge_addr);
- _params.__set_rid_to_target_param(rid_to_target_param);
_params.__set_runtime_filter_builder_num(runtime_filter_builder_num);
_params.__set_rid_to_target_paramv2(rid_to_target_paramv2);
}
diff --git a/gensrc/proto/column_data_file.proto
b/gensrc/proto/column_data_file.proto
deleted file mode 100644
index b8bd15833e0..00000000000
--- a/gensrc/proto/column_data_file.proto
+++ /dev/null
@@ -1,68 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-syntax="proto2";
-
-package doris;
-option java_package = "org.apache.doris.proto";
-
-import "olap_common.proto";
-
-message StreamInfoMessage {
- enum Kind {
- ROW_INDEX = 0;
- PRESENT = 1;
- DATA = 2;
- LENGTH = 3;
- DICTIONARY_DATA = 4;
- SECONDARY = 5;
- ROW_INDEX_STATISTIC = 6;
- BLOOM_FILTER = 7;
- }
- required Kind kind = 1;
- required uint32 column_unique_id = 2;
- required uint64 length = 3;
-}
-
-message ColumnEncodingMessage {
- enum Kind {
- DIRECT = 0;
- DICTIONARY = 1;
- }
- optional Kind kind = 1;
- optional uint32 dictionary_size = 2;
-}
-
-message ColumnDataHeaderMessage {
- required string magic_string = 1 [default = "COLUMN DATA"];
- required uint32 version = 2 [default = 1];
- required uint64 number_of_rows = 4;
- // column schema
- repeated ColumnMessage column = 5;
- // statistics for each column
- required uint64 index_length = 7;
- required uint64 data_length = 8;
- required CompressKind compress_kind = 9 [default = COMPRESS_LZO];
- repeated StreamInfoMessage stream_info = 10;
- repeated ColumnEncodingMessage column_encoding = 11;
- required uint32 stream_buffer_size = 12;
- optional uint32 num_rows_per_block = 13 [default = 0];
- // bloom filter params
- optional uint32 bf_hash_function_num = 14;
- optional uint32 bf_bit_num = 15;
-}
-
diff --git a/gensrc/proto/internal_service.proto
b/gensrc/proto/internal_service.proto
index c5818339f3a..606bd7aff16 100644
--- a/gensrc/proto/internal_service.proto
+++ b/gensrc/proto/internal_service.proto
@@ -155,31 +155,6 @@ message PTabletWriterOpenResult {
repeated PTabletLoadRowsetInfo tablet_load_rowset_num_infos = 2;
};
-// add batch to tablet writer
-message PTabletWriterAddBatchRequest {
- required PUniqueId id = 1;
- required int64 index_id = 2;
- required int32 sender_id = 3;
-
- // If this is the last batch from this sender
- optional bool eos = 4;
-
- required int64 packet_seq = 5;
- repeated int64 tablet_ids = 6;
- // unset if and only if when eos is true
- optional PRowBatch row_batch = 7;
- // only valid when eos is true
- // valid partition ids that would write in this writer
- repeated int64 partition_ids = 8;
- // the backend which send this request
- optional int64 backend_id = 9 [default = -1];
- // transfer the RowBatch to the Controller Attachment
- optional bool transfer_by_attachment = 10 [default = false];
- optional bool is_high_priority = 11 [default = false];
- optional bool write_single_replica = 12 [default = false];
- map<int64, PSlaveTabletNodes> slave_tablet_nodes = 13;
-};
-
message PTabletWriterAddBlockRequest {
required PUniqueId id = 1;
required int64 index_id = 2;
@@ -228,21 +203,6 @@ message PTabletError {
optional string msg = 2;
}
-message PTabletWriterAddBatchResult {
- required PStatus status = 1;
- repeated PTabletInfo tablet_vec = 2;
- optional int64 execution_time_us = 3;
- optional int64 wait_lock_time_us = 4;
- optional int64 wait_execution_time_us = 5;
- repeated PTabletError tablet_errors = 6;
- map<int64, PSuccessSlaveTabletNodeIds> success_slave_tablet_node_ids = 7;
-
- // For cloud
- optional int64 build_rowset_latency_ms = 1000;
- optional int64 commit_rowset_latency_ms = 1001;
- repeated PTabletLoadRowsetInfo tablet_load_rowset_num_infos = 1002;
-};
-
message PTabletWriterAddBlockResult {
required PStatus status = 1;
repeated PTabletInfo tablet_vec = 2;
diff --git a/gensrc/proto/olap_common.proto b/gensrc/proto/olap_common.proto
index 0a33bc9ee6c..2c18ff70fb8 100644
--- a/gensrc/proto/olap_common.proto
+++ b/gensrc/proto/olap_common.proto
@@ -21,44 +21,12 @@ syntax="proto2";
package doris;
option java_package = "org.apache.doris.proto";
-message ColumnMessage {
- required string name = 1; // ColumnPB.name
- required string type = 2; // ColumnPB.type
- required string aggregation = 3; // ColumnPB.aggregation
- required uint32 length = 4; // ColumnPB.length
- required bool is_key = 5; // ColumnPB.is_key
- optional string default_value = 6; // ColumnPB.default_value
- optional string referenced_column = 7; // deprecated
- optional uint32 index_length = 8; // ColumnPB.index_length
- optional uint32 precision = 9 [default = 27]; // ColumnPB.precision
- optional uint32 frac = 10 [default = 9]; // ColumnPB.frac
- optional bool is_allow_null = 11 [default=false]; // ColumnPB.is_nullable
- optional uint32 unique_id = 12; // ColumnPB.unique_id
- repeated uint32 sub_column = 13; // not used
- optional bool is_root_column = 14 [default=false]; // not used
- // is bloom filter column
- optional bool is_bf_column = 15 [default=false]; //
ColumnPB.is_bf_column
- // is bitmap index column
- optional bool has_bitmap_index = 16 [default=false]; // deprecated
-}
-
enum CompressKind {
COMPRESS_NONE = 0;
COMPRESS_LZO = 1;
COMPRESS_LZ4 = 2;
}
-message PCounter {
- required string item = 1;
- required uint64 count = 2;
-}
-
-message PTopNCounter {
- required uint32 top_num = 1;
- required uint32 space_expand_rate = 2;
- repeated PCounter counter = 3;
-}
-
enum FileType {
SEGMENT_FILE = 1;
INVERTED_INDEX_FILE = 2;
diff --git a/gensrc/thrift/PaloInternalService.thrift
b/gensrc/thrift/PaloInternalService.thrift
index 7b628a70e69..33c7450419c 100644
--- a/gensrc/thrift/PaloInternalService.thrift
+++ b/gensrc/thrift/PaloInternalService.thrift
@@ -519,13 +519,6 @@ struct TScanRangeParams {
2: optional i32 volume_id = -1
}
-// deprecated
-struct TRuntimeFilterTargetParams {
- 1: required Types.TUniqueId target_fragment_instance_id
- // The address of the instance where the fragment is expected to run
- 2: required Types.TNetworkAddress target_fragment_instance_addr
-}
-
struct TRuntimeFilterTargetParamsV2 {
1: required list<Types.TUniqueId> target_fragment_instance_ids
// The address of the instance where the fragment is expected to run
@@ -537,10 +530,6 @@ struct TRuntimeFilterParams {
// Runtime filter merge instance address. Used if this filter has a remote
target
1: optional Types.TNetworkAddress runtime_filter_merge_addr
- // keep 2/3/4/5 unset if BE is not used for merge
- // deprecated
- 2: optional map<i32, list<TRuntimeFilterTargetParams>> rid_to_target_param
-
// Runtime filter ID to the runtime filter desc
// Used if this filter has a remote target
3: optional map<i32, PlanNodes.TRuntimeFilterDesc> rid_to_runtime_filter
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
