github-actions[bot] commented on code in PR #15399: URL: https://github.com/apache/doris/pull/15399#discussion_r1059424676
########## be/src/vec/core/block_spill_writer.h: ########## @@ -0,0 +1,65 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "io/local_file_writer.h" +#include "vec/core/block.h" +namespace doris { +namespace vectorized { + +// Write a block to a local file. +// +// The block may be logically splitted to small sub blocks in the single file, +// which can be read back one small block at a time by BlockNativeReader::get_next. +// +// Split to small blocks is necessary for Sort node, which need to merge multiple +// spilled big sorted blocks to a bigger sorted block. A small block is read from each +// spilled block file. +class BlockSpillWriter { +public: + BlockSpillWriter(int64_t id, size_t batch_size, const std::string& file_path) + : stream_id_(id), batch_size_(batch_size), file_path_(file_path) {} + + Status open(); + + Status close(); + + Status write(const Block& block); + + int64_t get_id() const { return stream_id_; } + +private: + Status _write_internal(const Block& block); + +private: Review Comment: warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers] ```suggestion ``` **be/src/vec/core/block_spill_writer.h:45:** previously declared here ```cpp private: ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
