yiguolei commented on code in PR #15399: URL: https://github.com/apache/doris/pull/15399#discussion_r1059260290
########## be/src/vec/core/block_spill_writer.cpp: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/core/block_spill_writer.h" + +#include "agent/be_exec_version_manager.h" +#include "io/file_factory.h" +#include "io/local_file_writer.h" +#include "runtime/runtime_state.h" + +namespace doris { +namespace vectorized { +Status BlockSpillWriter::write(const Block& block) { + std::unique_ptr<doris::FileWriter> file_writer; + + RETURN_IF_ERROR(FileFactory::create_file_writer(TFileType::FILE_LOCAL, ExecEnv::GetInstance(), Review Comment: 这里不能假定一个writer 一次就写入一个block， 他可以写入多个block，所以应该把file_writer的open 放到 spill manager 创建writer的过程中。 然后writer 提供一个close 方法，供调用。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
