github-actions[bot] commented on code in PR #64301:
URL: https://github.com/apache/doris/pull/64301#discussion_r3427464179
##########
fs_brokers/cdc_client/src/main/java/org/apache/doris/cdcclient/service/PipelineCoordinator.java:
##########
@@ -406,6 +409,13 @@ public CompletableFuture<Void>
writeRecordsAsync(WriteRecordRequest writeRecordR
closeJobStreamLoad(writeRecordRequest.getJobId());
String rootCauseMessage =
ExceptionUtils.getRootCauseMessage(ex);
taskErrorMaps.put(writeRecordRequest.getTaskId(),
rootCauseMessage);
+ taskProgressMap.remove(writeRecordRequest.getTaskId());
+ DorisBatchStreamLoad.reportTaskFailure(
+ writeRecordRequest.getFrontendAddress(),
Review Comment:
After the new push path succeeds, this stored failure reason no longer has a
consumer. `reportTaskFailure()` can pause the FE job immediately, so
`processTimeoutTasks()` stops polling `/api/getTaskStatus` for this task; task
IDs are unique, and neither `/api/close` nor `/api/releaseReader` clears
`taskErrorMaps`. With auto-resume and repeated write failures, the CDC client
retains one entry per failed task. Please make the push report whether FE
accepted the failure and remove the entry on success, or add another
bounded/explicit cleanup path while keeping the entry only when the push is
lost so polling remains the backstop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
