github-actions[bot] commented on code in PR #64301:
URL: https://github.com/apache/doris/pull/64301#discussion_r3426004165
##########
fs_brokers/cdc_client/src/main/java/org/apache/doris/cdcclient/service/PipelineCoordinator.java:
##########
@@ -406,6 +409,13 @@ public CompletableFuture<Void>
writeRecordsAsync(WriteRecordRequest writeRecordR
closeJobStreamLoad(writeRecordRequest.getJobId());
Review Comment:
Please clear the progress entry before publishing the one-shot error, or
make `getTaskStatus` give `failReason` priority over progress. In the current
ordering, a scheduler `/api/getTaskStatus` can interleave after
`taskErrorMaps.put(...)` but before this `taskProgressMap.remove(...)`, so it
returns the previous positive `scannedRows` together with the new failure
reason. FE then treats the higher `scannedRows` as progress in
`isTimeout(status)`, returns `false`, and `getTaskStatus` has already removed
the failure reason. The task stays `RUNNING` until another timeout and loses
the real write error, which breaks the immediate failure-reporting path this PR
adds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
